uPortal
  1. uPortal
  2. UP-3269

If you turn off 'Add Columns' for fragment and then change the layout and add a column, it throws a NPE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.2
    • Fix Version/s: 4.0.6
    • Component/s: None
    • Labels:

      Description

      If you turn off Add Columns for a fragment, and then change the layout by adding a columns (i.e. two columns, then select the three columns option), it will throw an NPE in the logs and give you 'An Unknown error occurred' alert).

      ERROR [http-8080-1] Dec/21 15:31:34,837 remoting.UpdatePreferencesServlet.[] - java.lang.NullPointerException
      java.lang.NullPointerException
      at org.jasig.portal.layout.dlm.remoting.UpdatePreferencesServlet.changeColumns(UpdatePreferencesServlet.java:324)
      at org.jasig.portal.layout.dlm.remoting.UpdatePreferencesServlet.doPost(UpdatePreferencesServlet.java:151)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

      This relates to UP-3268 where the user should not be given the option to perform this action.

      uP4 is also affected except you get no feedback at all, only an error in the Web Inspector:
      POST https://up40-nightly.jasig.org/api/layout 500 (Internal Server Error)

        Issue Links

          Activity

          Hide
          Steve Swinsburg added a comment -

          Ill be working on this in the near future as this is an issue for us.

          Show
          Steve Swinsburg added a comment - Ill be working on this in the near future as this is an issue for us.
          Hide
          Jennifer Bourey added a comment -

          Hi Steve,

          uPortal 3 and uPortal 4 have completely separate user interface code for column selection. Have you observed this issue in both versions, or just in one?

          Show
          Jennifer Bourey added a comment - Hi Steve, uPortal 3 and uPortal 4 have completely separate user interface code for column selection. Have you observed this issue in both versions, or just in one?
          Hide
          Steve Swinsburg added a comment -

          Hi Jen,
          The bug is present in both, although uPortal 4 exhibits a different error (see the end of the description above).

          Show
          Steve Swinsburg added a comment - Hi Jen, The bug is present in both, although uPortal 4 exhibits a different error (see the end of the description above).
          Hide
          Jennifer Bourey added a comment -

          I've done a bit of research, and while our javascript implementation is successfully calculating the allowed layouts and adding disabled properties to forbidden layout options, those options aren't really treated as disabled. Preventing any action when the user clicks those is simple, but we need some UX assistance to grey out the unavailable options.

          Show
          Jennifer Bourey added a comment - I've done a bit of research, and while our javascript implementation is successfully calculating the allowed layouts and adding disabled properties to forbidden layout options, those options aren't really treated as disabled. Preventing any action when the user clicks those is simple, but we need some UX assistance to grey out the unavailable options.
          Hide
          Jacob Lichner added a comment -

          Submitted a fix for this issue on GitHub and attaching a screenshot here for the record showing what disabled layouts now appear as (and of course, you can no longer click on them).

          Show
          Jacob Lichner added a comment - Submitted a fix for this issue on GitHub and attaching a screenshot here for the record showing what disabled layouts now appear as (and of course, you can no longer click on them).

            People

            • Assignee:
              Steve Swinsburg
              Reporter:
              Steve Swinsburg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: