Student Success Plan
  1. Student Success Plan
  2. SSP-1833

Challenge Referral Links not copied into MyGPS-created action plan tasks

    Details

      Description

      Reported in the field (2.0.1), verified locally (2.0.1) and in Linux CI (2.1.0)...

      1) Create an action plan task in MyGPS by clicking on a Referral (i.e. Resource)
      2) A task will appear in the right hand panel and will display the Referral's "public description" (if it exists, else the non-public description) but will not display the link associated with the Referral.
      3) Clicking on the Referral launches a dialog that also displays the public description (or the non-public description if the public one doesn't exist) but not the link.

      The link should appear along with the public description (or non-public description if the public description doesn't exist) in both #2 and #3.

      This does work when a Task is created from the SSP app, just not from MyGPS.

      Also, worth pointing out, at least for posterity, that both the description (public or otherwise) and the link are copied into the Task record. So subsequent changes to the underlying Referral won't be reflected in existing Tasks. So the problem would seem to have to do with MyGPS not using exactly the same Referral cloning logic.

      Question for Jason... as part of a fix, should we take it upon ourselves to copy links into existing Tasks? I would argue we should not if the actual design intent is to preserve original Referral state whenever creating Tasks; i.e. we don't have any good way to know if the Referral had or didn't have a link when any given Task was originally created. It's not impossible to copy links into existing Tasks... but I'm not sure we know if that's actually what people want/expect?

        Issue Links

          Activity

          Hide
          Dan McCallum added a comment -

          I'm going to make an executive decision and copy any non-null Referral link into any associated task for which the link column is null. Can't imagine a good reason why you'd want to preserve a blank link in an existing task if the Referral now has a link. Closest I can think up is wanting to preserve some sort of audit-ish-ability for existing tasks ("I didn't know what to do b/c the Task didn't have a link when it was assigned!") But we don't really support that... you can edit Tasks whenever and there's no actual "trail" of what changed. And I know in the field we've got at least one deployment complaining that they've configured a bunch of links and they're not showing up.

          Show
          Dan McCallum added a comment - I'm going to make an executive decision and copy any non-null Referral link into any associated task for which the link column is null. Can't imagine a good reason why you'd want to preserve a blank link in an existing task if the Referral now has a link. Closest I can think up is wanting to preserve some sort of audit-ish-ability for existing tasks ("I didn't know what to do b/c the Task didn't have a link when it was assigned!") But we don't really support that... you can edit Tasks whenever and there's no actual "trail" of what changed. And I know in the field we've got at least one deployment complaining that they've configured a bunch of links and they're not showing up.
          Hide
          Dan McCallum added a comment - - edited

          Pushed a commit to rel-2-0-patches for 2.0.1. Still needs to be merged up to master (2.1.0). Leaving the merge-to-2-0 label on, as usual, to help track all these 11th hour fixes.

          Show
          Dan McCallum added a comment - - edited Pushed a commit to rel-2-0-patches for 2.0.1. Still needs to be merged up to master (2.1.0). Leaving the merge-to-2-0 label on, as usual, to help track all these 11th hour fixes.
          Hide
          Jason Elwood added a comment -

          QAa'd in rel-2-0-patches, waiting for merge to 2.1 and 2.2 for QA

          Show
          Jason Elwood added a comment - QAa'd in rel-2-0-patches, waiting for merge to 2.1 and 2.2 for QA
          Hide
          Dan McCallum added a comment -

          Cherry-picked into rel-2-1-patches for 2.1.0. Still needs to be cherry-picked into master (2.2.0). Leaving both merge labels attached pending QA.

          Show
          Dan McCallum added a comment - Cherry-picked into rel-2-1-patches for 2.1.0. Still needs to be cherry-picked into master (2.2.0). Leaving both merge labels attached pending QA.
          Hide
          Jason Elwood added a comment -

          QA'd in 2.1 for the copy action. Created SSP-1854 for 2.2 to include the link on printed and emailed reported. Ready for merge to 2.2

          Show
          Jason Elwood added a comment - QA'd in 2.1 for the copy action. Created SSP-1854 for 2.2 to include the link on printed and emailed reported. Ready for merge to 2.2
          Hide
          Dan McCallum added a comment -

          Cherry-picked into master for 2.2.0. Leaving merge-to-2-2 label attached pending QA.

          Show
          Dan McCallum added a comment - Cherry-picked into master for 2.2.0. Leaving merge-to-2-2 label attached pending QA.

            People

            • Assignee:
              Dan McCallum
              Reporter:
              Dan McCallum
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: