Student Success Plan
  1. Student Success Plan
  2. SSP-1790

Unpredictable MAP term grid contents when more than 20 records in external_term

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: SSP 2.0.0, SSP 2.1.0, SSP 2.0.1
    • Fix Version/s: SSP 2.1.0, SSP 2.0.1
    • Component/s: External Data, MAP
    • Labels:
      None

      Description

      Observed in the field... a deployer has 250+ records in the external_term table and the end result is a single, seemingly random "semester panel" in the MAP UI. This happens because the client-side selection of current and future terms relies on the "main" term store having loaded all terms into memory, which it typically hasn't (just has the first page). So if you have more than 20 terms in the db and the first page of results doesn't include the "current" term, the results are effectively unpredictable. Through what amounts to an accident of logic, the UI picks the "first" term on the first result page, where "first" could mean any number of things depending on how server- and client-side sorts were applied.

      The short term fix is going to be to load all terms into the term store. The long term fix should be to delegate lookup of current and future terms to the server, even if just because date-based calculations on the client side are always a bad idea. But more generally to ensure the calculation logic is always consistent.

        Issue Links

          Activity

          Hide
          Dan McCallum added a comment -

          Fixed in master (2.1.0) and rel-2-0-patches (2.0.1).

          Note that this also affects Intake -> Edu Goal -> Anticipated Graduation Date

          Show
          Dan McCallum added a comment - Fixed in master (2.1.0) and rel-2-0-patches (2.0.1). Note that this also affects Intake -> Edu Goal -> Anticipated Graduation Date
          Hide
          Dan McCallum added a comment -

          FWIW, i tested this by blowing away what I had in external_term and running that attached external_term_unique.sql to load a large number of terms. Without the patch I would then get only the "Fall 1967" term in MAP.

          Show
          Dan McCallum added a comment - FWIW, i tested this by blowing away what I had in external_term and running that attached external_term_unique.sql to load a large number of terms. Without the patch I would then get only the "Fall 1967" term in MAP.
          Hide
          Dan McCallum added a comment -

          I added the merge-to-2-0 label back even though this has already been merged just to indicate that it hasn't actually been tested by anyone other than myself.

          Show
          Dan McCallum added a comment - I added the merge-to-2-0 label back even though this has already been merged just to indicate that it hasn't actually been tested by anyone other than myself.
          Hide
          Dan McCallum added a comment -

          Reopening so I can leave this in a Resolved state until the 2.0.1 backport is checked.

          Show
          Dan McCallum added a comment - Reopening so I can leave this in a Resolved state until the 2.0.1 backport is checked.
          Hide
          Dan McCallum added a comment -

          Ready for test in 2.0.1 (rel-2-0-patches)

          Show
          Dan McCallum added a comment - Ready for test in 2.0.1 (rel-2-0-patches)

            People

            • Assignee:
              Dan McCallum
              Reporter:
              Dan McCallum
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: