Jasig CAS Client for Java
  1. Jasig CAS Client for Java
  2. CASC-172

Cas20ServiceTicketValidator is waiting for PGT whereas configuration states not to

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: Java
    • Labels:
      None

      Description

      When Cas20ProxyReceivingTicketValidationFilter is configured in web.xml to accept proxy-tickets (acceptAnyProxy or allowedProxyChains), even if proxyCallbackUrl or proxyReceptorUrl are not defined, the log shows this entry : No Proxy Ticket found for [].
      This indicates it's still waiting for a PGT. Indeed, looking at Cas20ServiceTicketValidator code (parseResponseFromServer method), we can see on line 91 there is a call to proxyGrantingTicketStorage.retrieve which generates the faulty log entry.
      In Cas20ProxyReceivingTicketValidationFilter the attribute proxyGrantingTicketStorage is instantiated, so is never null (that's the test used to call or not the proxyGrantingTicketStorage.retrieve).

        Activity

        Hide
        Scott Battaglia added a comment -

        I'm not sure I follow the part where it says its "waiting" for a PGT. Its checking unnecessarily. Possibly an optimization to not do the get, but its not waiting on anything as far as I know.

        Show
        Scott Battaglia added a comment - I'm not sure I follow the part where it says its "waiting" for a PGT. Its checking unnecessarily. Possibly an optimization to not do the get, but its not waiting on anything as far as I know.
        Hide
        Olivier Daroux added a comment -

        I didn't used the correct words
        You're right, it's not waiting for, but there is an unnecessary call, and an unnecessary log entry

        Feel free to change the title of the "bug"

        Show
        Olivier Daroux added a comment - I didn't used the correct words You're right, it's not waiting for, but there is an unnecessary call, and an unnecessary log entry Feel free to change the title of the "bug"
        Hide
        Scott Battaglia added a comment -

        No worries, just wanted to make sure it wasn't doing anything really bad

        I'll get this into 3.3

        Show
        Scott Battaglia added a comment - No worries, just wanted to make sure it wasn't doing anything really bad I'll get this into 3.3

          People

          • Assignee:
            Scott Battaglia
            Reporter:
            Olivier Daroux
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: