CAS Server
  1. CAS Server
  2. CAS-981

Remove final on AbstractLdapUsernamePasswordAuthenticationHandler.afterPropertiesSet()

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.7
    • Fix Version/s: 3.4.9
    • Component/s: LDAP
    • Labels:
      None
    • Environment:
      all

      Description

      Remove the final modifier on the AbstractLdapUsernamePasswordAuthenticationHandler.afterPropertiesSet-method or provide s.th. like afterPropertiesSetInternal() which can be implemented in subclasses. - Otherwise it's not possible to implement custom asserts.

        Activity

        Hide
        Scott Battaglia added a comment -

        what are you trying to assert that can't be checked with the annotations?

        If there's a legit issue, we'll add an afterPropertiesSetInternal

        Thanks
        Scott

        Show
        Scott Battaglia added a comment - what are you trying to assert that can't be checked with the annotations? If there's a legit issue, we'll add an afterPropertiesSetInternal Thanks Scott

          People

          • Assignee:
            Scott Battaglia
            Reporter:
            Odilo Oehmichen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: