CAS Server
  1. CAS Server
  2. CAS-1072

Improve ServicesManager.save() API to return the merged RegisteredService rather than returning void

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0 RC1, 3.5.0
    • Component/s: None
    • Labels:
      None

      Description

      ServicesManager.save() currently returns void rather than the merged RegisteredService. (When one saves a RegisteredService without an existing id, it has the effect of assigning it an id.) Returning the merged object could simplify calling code which currently has to findServiceBy() to reliably get the merged RegisteredService.

      As discussed at https://github.com/apetro/cas/commit/cfedef316d81694e3f43a56f8840ac957ebcdbe7 .

      API change inappropriate for a patch release.

      This is a modest API change to an API blessedly not enumerated as public here http://www.jasig.org/cas/public-api, so it can be evolved for the CAS 3.5 release.

        Activity

        Hide
        Dmitriy Kopylenko added a comment -

        Merged into 'master'

        Show
        Dmitriy Kopylenko added a comment - Merged into 'master'

          People

          • Assignee:
            Andrew Petro
            Reporter:
            Andrew Petro
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: